search

microsoft / azure-pipelines-language-server

A language server for Azure Pipelines YAML
37 stars 25 forks source link

Correctly handle emojis in YAML #116

Closed PaulTaykalo closed 2 years ago

PaulTaykalo commented 2 years ago

Update handling of emojis in the YAML.

This seems to be fixed in the yaml-ast-parser already. https://github.com/mulesoft-labs/yaml-ast-parser/releases/tag/0.0.43

This should fix https://github.com/microsoft/azure-pipelines-vscode/issues/384, once this merged in

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

50Wliu commented 2 years ago

Oh, sweet! I'll take this for a spin and merge it if things look good. Great find!

50Wliu commented 2 years ago

Worked like a charm. Thanks for your contribution! I'll ship this as part of the Sprint 195 update.

krokofant commented 2 years ago

Wow! Thank you 😍🚀

krokofant commented 2 years ago

@50Wliu Any idea when that will be released? I have no idea how to track that sprint 🤔

50Wliu commented 2 years ago

Gooood question! I'm not actually on the ADO team so I have no idea. I did find https://whatsprintis.it/calendar which gives a general idea...and based on the release notes it seems like they're on a three-week release cycle that lags behind the current sprint by one release.

The reason I want to correlate this with the next sprint release is the pipeline schema gets refreshed every sprint, so I can also provide an updated schema.