search

microsoft / azure-pipelines-language-server

A language server for Azure Pipelines YAML
38 stars 25 forks source link

Fix language-service build #92

Closed winstliu closed 3 years ago

winstliu commented 3 years ago

Surprise, more dependency upgrades.

I have absolutely no context on why a UMD module is needed so I can't test it to make sure nothing broke by changing from Webpack 4/Uglify to Webpack 5/Terser.

(The underlying issue causing the failing build seems to be that Uglify is unsupported, and vscode-uri@3 uses newer JS features than it can support. Webpack 5 switches to the Terser plugin as a replacement.)

vtbassmatt commented 3 years ago

We'll merge this despite failing CI, because there's a dependency between server/service that will only be resolved after shipping. (Yes, gross, but that's where we are 🤣 )