search

microsoft / azure-pipelines-tasks-common-packages

MIT License
23 stars 36 forks source link

Hard Coded API version in API call not compatible with Azure Stack Hub #361

Open trx1 opened 1 month ago

trx1 commented 1 month ago

The function with the issue:

getSitePublishingCredentialPolicies() in azure-pipelines-tasks-common-packages/common-npm-packages/azurermdeploycommon/azure-arm-rest/azure-arm-app-service.ts

The issue:

This function passes api version '2022-03-01' which is not supported by Azure Stack Hub. This is called by Azure Devop's 'Azure App Service deploy' task (https://github.com/microsoft/azure-pipelines-tasks/tree/c61bf51acafa7f1b51b2b7271d766a0e5bdc6003/Tasks/AzureRmWebAppDeploymentV4) which is used on Azure DevOps Server. The upgrade of Azure DevOps Server installed the newer incompatible version which broke all deployments in our organization using that deployment task.

The fix:

Pass the API version of '2020-12-01' or better yet, check what versions are supported and don't use an unsupported version.

Line of code reference:

https://github.com/microsoft/azure-pipelines-tasks-common-packages/blob/627aa16e079e9f783901e73e6704548e432a8e59/common-npm-packages/azurermdeploycommon/azure-arm-rest/azure-arm-app-service.ts#L567

Bug introduced in this commit:

https://github.com/microsoft/azure-pipelines-tasks-common-packages/commit/885a11f109c5bab59bc05547064381d5d88f8174#diff-0a2aa407bd15f8009b4661e830703df84cef0cc4cced168290d308c3feaacb7a

ismayilov-ismayil commented 1 month ago

Hi @trx1, thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.