Repository type "git" should be accepted; corresponds to Azure Repos

[vtbassmatt]

Behavior in 1.147.1:

[vtbassmatt]

In 1.152.0, this regressed further. Nothing under the repositories: key is suggested anymore.

[damccorm]

Nothing under the key is suggested at all? Or no suggestions are showing up under type? From what I can see, the type not showing up makes sense and is expected given the current schema (and is a relatively easy fix). But if its not suggesting anything at all under repositories, I'm not certain that's a schema bug.

The repositories definition looks like:

"repositories":{"description":"List of external repositories","$ref":"#/definitions/repositoryResources"}},
[...]
"repositoryResources":{"type":"array","items":{"$ref":"#/definitions/repositoryResource"}},
"repositoryResource":{"type":"object","properties":{
   "repository":{"description":"ID of the external repository", "$ref":"#/definitions/referenceName"},
   "endpoint":{"description":"ID of the service endpoint connecting to this repository","$ref":"#/definitions/nonEmptyString"},
   "checkoutOptions":{"deprecationMessage":"This location is deprecated, `checkoutOptions` should be a peer of the `repository` keyword.","doNotSuggest":true,"$ref":"#/definitions/repositoryCheckoutOptions"}
}, "additionalProperties":true,"firstProperty":["repository"],"required":["repository"]}

It looks like repository, endpoint, and checkoutOptions should at least show up given this schema

[damccorm]

We're definitely missing the enum for type though

[vtbassmatt]

[damccorm]

@joscol given comments above I think this might be an issue with the language service

[vtbassmatt]

This is still broken in https://github.com/microsoft/azure-pipelines-vscode/releases/tag/v1.155.0 which contains the updated language service.