search

microsoft / azure-pipelines-yaml

Azure Pipelines YAML examples, templates, and community interaction
MIT License
1.21k stars 934 forks source link

Update deployment.yml to apps/v1 from apps/v1beta1 so that it works on aks clusters created without specifying older versions of kubernetes. #509

Closed raboley closed 4 years ago

raboley commented 4 years ago

This is a proposed fix for #508

When following the instructions for Build and deploy to Azure Kubernetes Service even by following the instructions exactly it will cause a fail on deployment due to changes in the kubernetes api on newer version of AKS.

My change will update the manifest version that will work on newer versions of Kubernetes that get created by default when not specifying the version and creating an aks cluster. I would propose an optional change to the documentation as well to specify a version so that in the future this wouldn't cause examples to no longer work as the api changes and can be seen at my PR here

ghost commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: raboley sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

raboley commented 4 years ago

Looks like this got updated elsewhere. Closing issue!