microsoft / azure-pipelines-yaml

Azure Pipelines YAML examples, templates, and community interaction
MIT License
1.19k stars 926 forks source link

Changed api-version to v1 and added matchLabels to deployment spec #510

Closed anraghun closed 3 years ago

anraghun commented 3 years ago

Upgraded the api-version to apps/v1 as apps/v1beta1 got deprecated and is causing the pipeline to fail.

shigupt202 commented 3 years ago

NIT: This is supported on kubernetes versions >= 1.16. For previous versions, the existing template is still valid. Should we explicitly call out about the version somewhere?

anraghun commented 3 years ago

Will apps/v1 be backwards compatible for older versions? If not, we should call it out in the doc for "Deploy to AKS" starter pipeline.

shigupt202 commented 3 years ago

According to the kubernetes documentation, apps/v1 is available since v1.9. So, it should be compatible with most of the older clusters.

anraghun commented 3 years ago

Okay, I'll add the details to the doc as well.