microsoft / azure-privacy-sandbox-kms

MIT License
5 stars 10 forks source link

Prepare for using azure cleanroom in tests #214

Closed DomAyre closed 2 days ago

DomAyre commented 1 week ago

Motivation

When attempting to add azure cleanroom support, I noticed that the KMS code defines a "workspace" which is assumed to have the same structure as the workspace created when running sandbox.sh from ghcr.io/microsoft/ccf/app/dev/${CCF_PLATFORM}:${TAG}.

Since the network created by azure cleanroom doesn't have this structure we need to update the code that has this assumption.

Changes

beejones commented 3 days ago

we are missing tests for keyunwrap

DomAyre commented 3 days ago

we are missing tests for keyunwrap

I agree, that isn't for this PR to address, see the original PR which added these tests. (There's a few tests which weren't completed and I deferred for future PRs because I had to work on other things)

I need to prioritise working on the self hosting of CCF over the KMS's test coverage, but it would be great if you could add the missing tests in a future PR

DomAyre commented 2 days ago

Putting back into draft state while I fix some non-trivial merge conflicts with the settingsPolicy PR

DomAyre commented 2 days ago

Merge conflicts are done, back to "ready to review"