microsoft / azure-redcap-paas

Automated deployment of REDCap with Azure Blob storage as the storage back-end
MIT License
28 stars 55 forks source link

Adding resources to match terraform #22

Closed matheuscarboni closed 1 year ago

matheuscarboni commented 1 year ago

Adding:

TODO:

matheuscarboni commented 1 year ago

@microsoft-github-policy-service agree

pauldotyu commented 1 year ago

Hey @matheuscarboni and @SvenAelterman. I took a look at changes and it all seems fine to me but IMO, I don't think the azuredeploy.bicep file should be overwritten to include these "secure" features. The azuredeploy.bicep should be treated as a "quickstart" and be as simple as possible so folks can deploy and test a "plain" instance of REDCap that doesn't take dependencies on a bunch of other Azure services, even though it is unsecure. Perhaps the changes proposed here should be in a new file called azuredeploysecure.bicep or some other name that makes sense.

matheuscarboni commented 1 year ago

@pauldotyu - makes sense to me, I went ahead and made the changes to keep things separate

@SvenAelterman - I am working on a separate branch for the other fixes here: https://github.com/matheuscarboni/azure-redcap-paas/tree/modules-fix

pauldotyu commented 1 year ago

LGTM