search

microsoft / azure-spring-boot

Spring Boot Starters for Azure services
MIT License
376 stars 460 forks source link

Use single version for whole project #500

Closed Incarnation-p-lee closed 5 years ago

Incarnation-p-lee commented 5 years ago

Current we have to edit 17 lines for version upgrade, should depend on one and only one version for this repo.

Incarnation-p-lee commented 5 years ago

We can leverage maven revision place holder to archive this target.

LennartHaggkvistHM commented 5 years ago

Please note that if you use ${revision} then the public advice is to use flatten-maven-plugin - but that one alters the pom files in a lot of ways. More information: https://github.com/mojohaus/flatten-maven-plugin/issues/51

Incarnation-p-lee commented 5 years ago

@LennartHaggkvistHM Thanks for your information, We decide to clean up this as it is stupid to change the version in about 20 locations for each version upgrading. We may follow the rules from spring boot project and only leverage ${revision} in this repo. Please correct me if something misleading.

LennartHaggkvistHM commented 5 years ago

@Incarnation-p-lee My experience is that it can be a problem - so I would suggest that you a) check the installed files in your local mvn repo so that they doesn't contain ${revision} - they should contain the actual version. b) verify with another project using the new versions (ie - some other project using the snapshot version)

Incarnation-p-lee commented 5 years ago

@LennartHaggkvistHM You mean if other repo leverage ${revision} and depends on this package or this package dependencies with ${revision} will result in override or something mess. If yes, that may be a problem, need to investigate the risk before the PR.

Incarnation-p-lee commented 5 years ago

@LennartHaggkvistHM Thanks for you advice. My previous understanding is not very correct. ${revision} may be the mess even we leverage the plugin flatten-maven-plugin. As our dependency graph is different to spring-boot-project, the plugin doesn't not works very well.

We may consider to abandon ${revision}, and within that plugin the whole process may become complicated. We may prefer some simple way to resolve this, like some script to replace the version.

Incarnation-p-lee commented 5 years ago

close this issue due to abandon revision.

LennartHaggkvistHM commented 5 years ago

@Incarnation-p-lee there is now a new version of the flatten-maven-plugin that works better. I suggest that you test it. The example on https://maven.apache.org/maven-ci-friendly.html works better now.

Incarnation-p-lee commented 5 years ago

@LennartHaggkvistHM Good to learn this, we will have a try later.