microsoft / azure-tools-for-java

Azure tools for Java, including Azure Toolkits for Eclipse, IntelliJ and related projects.
Other
240 stars 161 forks source link

[IntelliJ][Spark][RunConf] Submit from context menu, config populated when local config has main class #1964

Closed jingyanjingyan closed 4 years ago

jingyanjingyan commented 6 years ago

Build: PR1888

Repro Steps:

  1. Create a sample project, right click on "SparkCore_WasbIOTest", click "Submit Spark Application to HDInsight"

  2. Enter values like change "numExecutor=1", enter command line arguments=1 image

  3. Click "Apply" to save the configuration then close

  4. Right click on "SparkCore_WasbIOTest", click "Submit Spark Application to HDInsight" to pops again, the values populates correctly

  5. Open the config file from Edit Configuration, click "Locally Run"

  6. Delete the value of "Job main class" and save

  7. Right click on "SparkCore_WasbIOTest", click "Submit Spark Application to HDInsight"

Result: The config use the default value, "numExecutor=1", and command line arguments=1 are not populated. image

Expect: Populate value or not should not depand on the local run main class?

wezhang commented 6 years ago

Should bind to the remote run main class

jingyanjingyan commented 6 years ago

Still repro with develop 848

wezhang commented 6 years ago

@konjac , could you help to have a look?

wezhang commented 5 years ago

It's better to take the mainclass field out of local run and remotely run configuration tabs

wezhang commented 4 years ago

The mainclass field has been taken out of local run and remotely run configuration tabs