This pull request primarily focuses on updating the usage of environment variables in the azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1 and azure_jumpstart_arcbox/artifacts/Bootstrap.ps1 scripts. The changes aim to improve consistency in the code by replacing instances of $env: with the direct use of the variable names. This will likely enhance readability and maintainability of the code.
The most important changes include:
In azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1:
Replaced $env:subscriptionId with $subscriptionId in the az login and Connect-AzAccount commands.
Updated the Get-Content command by replacing $Env:resourceGroup and $Env:subscriptionId with $resourceGroup and $subscriptionId respectively.
In the Connect-AzAccount and Get-AzConnectedMachine commands, replaced $env:spntenantId, $env:subscriptionId, and $env:resourceGroup with $spntenantId, $subscriptionId, and $resourceGroup respectively.
In azure_jumpstart_arcbox/artifacts/Bootstrap.ps1:
Replaced the environment variable names SPN_TENANT_ID and SPN_AUTHORITY with spnTenantId and spnAuthority respectively.
This pull request primarily focuses on updating the usage of environment variables in the
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
andazure_jumpstart_arcbox/artifacts/Bootstrap.ps1
scripts. The changes aim to improve consistency in the code by replacing instances of$env:
with the direct use of the variable names. This will likely enhance readability and maintainability of the code.The most important changes include:
In
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1
:$env:subscriptionId
with$subscriptionId
in theaz login
andConnect-AzAccount
commands.Get-Content
command by replacing$Env:resourceGroup
and$Env:subscriptionId
with$resourceGroup
and$subscriptionId
respectively.Connect-AzAccount
andGet-AzConnectedMachine
commands, replaced$env:spntenantId
,$env:subscriptionId
, and$env:resourceGroup
with$spntenantId
,$subscriptionId
, and$resourceGroup
respectively.In
azure_jumpstart_arcbox/artifacts/Bootstrap.ps1
:SPN_TENANT_ID
andSPN_AUTHORITY
withspnTenantId
andspnAuthority
respectively.