search

microsoft / azurechat

🤖 💼 Azure Chat Solution Accelerator powered by Azure Open AI Service
MIT License
1.24k stars 1.21k forks source link

Mobile View: Giving users the possibility to open and close the left menu containing the chat list #183

Closed giuliohome closed 1 year ago

giuliohome commented 1 year ago

Refer to the whole thread here. Related PR changes could be ported here into this repo as well.

Question: Do you find it reasonable for me to send a PR that includes both this enhancement for mobile view, allowing users to open and close the left menu containing the chat list, and the previously opened issue regarding title edit? These changes overlap in the code part related to the 'chat menu' component. Sending two separate PRs might introduce dependency issues, so combining them into one could simplify the process. Your feedback on this proposal is appreciated.

oliverlabs commented 1 year ago

Thanks, @giuliohome :)

@thivy, would you be OK with this functionality?

giuliohome commented 1 year ago

@oliverlabs they have done

oliverlabs commented 1 year ago

@giuliohome, yeah, I noticed. It's still not ideal, as the indentation for the chat conversation is not being aligned properly, but it is a good start. Do you know how to fix it?

Here's an example:

image
giuliohome commented 1 year ago

@oliverlabs It is the min width here in this class

class="flex flex-col min-w-[380px] max-w-[690px] border rounded-lg overflow-hidden p-4 gap-8"

giuliohome commented 1 year ago

@oliverlabs maybe it is enough to delete (or reduce) min-w-[380px] from this line

https://github.com/microsoft/azurechat/blob/main/src/components/chat/chat-row.tsx#L42

I'm under the impression that they don't want I touch the code though... I've already opened a PR and it has been ignored till now..

oliverlabs commented 1 year ago

@giuliohome, many thanks. This fixes the issue, indeed!