search

microsoft / azuredatastudio-postgresql

azuredatastudio-postgresql is an extension for Azure Data Studio that enables you to work with PostgreSQL databases
Other
192 stars 37 forks source link

Correct Service Install Folder to clean #428

Closed nasc17 closed 1 year ago

nasc17 commented 1 year ago

Is this a fix for issue 427? In that case, I think we need extensive tests like making online package -> downloading pgtoolsservice and repeating delete, download steps multiple times to see if it creates the same number of temp folders or not

This is at least the start. Checking to see how we were cleaning and that file path it was defining is not what we actually have. We can start to tests more with unstable build.

DaeunYim commented 1 year ago

Is this a fix for issue 427? In that case, I think we need extensive tests like making online package -> downloading pgtoolsservice and repeating delete, download steps multiple times to see if it creates the same number of temp folders or not

This is at least the start. Checking to see how we were cleaning and that file path it was defining is not what we actually have. We can start to tests more with unstable build.

I was thinking without merging this and waiting for unstable build, simply making a vsix file in your local version should be enough for testing