Add server objects to file picker

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.

https://learn.microsoft.com/sql/azure-data-studio

MIT License

7.54k stars 898 forks source link

Add server objects to file picker #11654

Open minoseah629 opened 4 years ago

minoseah629 commented 4 years ago

Is your feature request related to a problem? Please describe. In VS Code, user can hit control+p to quickly search for the files.

Also in VS Code, user can type in left panel and it searchs for file matching search criteria like below:

In ADS, Control + P searches files.
Typing in left panel does nothing

The closest existing feature in ADS is right click on the server or database and see this view: databases: tables:

Describe the solution or feature you'd like incorporate the control + p to use the search filters shown in screenshots above to allow for search for tables with t: tablename, etc for other database objects.

only allow active connections

Describe alternatives you've considered the forementioned existing features

adsbot[bot] commented 4 years ago

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

Charles-Gagnon commented 4 years ago

Closing this as a duplicate of https://github.com/microsoft/azuredatastudio/issues/8052

minoseah629 commented 4 years ago

@Charles-Gagnon, this issue you mentioned does not say anything about putting in the control + p thing is. i dont know what to call this control.

Charles-Gagnon commented 4 years ago

What are you suggesting that should do? Because as you mentioned it does currently search for files open in the workspace/folder. Is there further enhancement to that picker that you'd like to see?

minoseah629 commented 4 years ago

What are you suggesting that should do? Because as you mentioned it does currently search for files open in the workspace/folder. Is there further enhancement to that picker that you'd like to see?

I assume the OE Tree View is this left panel:

thats good.

but I asking to have the same features in the control + p :

the control + p feature specifically currently does files.

include the database objects and servers (if currently active connection) to this feature.

s:servername t:tablename f:functionname v:viewname

Charles-Gagnon commented 4 years ago

Gotcha, I updated the name for that portion of your ask as a separate issue from the OE filter. As for that one - stay tuned =)

minoseah629 commented 4 years ago

thanks @Charles-Gagnon .

the title just has server object.

just to be sure: does that include tables, functions, views, etc?

Charles-Gagnon commented 4 years ago

Yeah - "server objects" here is including all objects on a server.

Appreciate the feedback!