search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.56k stars 899 forks source link

Remote Jupyter Book dialog "Add" button is disabled #15524

Open barbaravaldez opened 3 years ago

barbaravaldez commented 3 years ago

bug

Cannot click on Add button after filling the dropdowns.

Steps to Reproduce: 1.Open Jupyter Remote Book

  1. Fill dropdowns
  2. Add button is disabled

Console error: workbench.desktop.main.js:2768 [[object Object]]Cannot read property 'filter' of undefined $onExtensionRuntimeError @ workbench.desktop.main.js:2768 _doInvokeHandler @ workbench.desktop.main.js:2288 _invokeHandler @ workbench.desktop.main.js:2288 _receiveRequest @ workbench.desktop.main.js:2288 _receiveOneMessage @ workbench.desktop.main.js:2288 (anonymous) @ workbench.desktop.main.js:2288 fire @ workbench.desktop.main.js:85 fire @ workbench.desktop.main.js:156 _receiveMessage @ workbench.desktop.main.js:156 (anonymous) @ workbench.desktop.main.js:156 fire @ workbench.desktop.main.js:85 acceptChunk @ workbench.desktop.main.js:156 (anonymous) @ workbench.desktop.main.js:156 I @ workbench.desktop.main.js:3584 emit @ events.js:315 addChunk @ _stream_readable.js:295 readableAddChunk @ _stream_readable.js:271 Readable.push @ _stream_readable.js:212 onStreamRead @ internal/stream_base_commons.js:186 workbench.desktop.main.js:2768 TypeError: Cannot read property 'filter' of undefined at t.RemoteBookDialog.fillLanguageDropdown (c:\Users\jukoesma\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\dist\extension.js:243:214890) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async c:\Users\jukoesma\AppData\Local\Programs\Azure Data Studio\resources\app\extensions\notebook\dist\extension.js:243:211494

barbaravaldez commented 3 years ago

@MsSQLGirl, I'm opening this issue to see if more people run into this.

@MaddyDev and I were not able to repro the disabled "Add" button, but I do see the console error when opening the dialog for the first time.

MsSQLGirl commented 3 years ago

I still can repro this issue in my environment: image Version: 1.30.0-insider (user setup) Commit: d04451985c5fcab79a2c51ef5c5d90a703872432 Date: 2021-06-07T05:38:06.575Z VS Code: 1.53.0 Electron: 11.2.2 Chrome: 87.0.4280.141 Node.js: 12.18.3 V8: 8.7.220.31-electron.0 OS: Windows_NT x64 10.0.19043

chlafreniere commented 3 years ago

Moving to backlog since it's no longer repro'ing. Will investigate and likely close soon.

chlafreniere commented 3 years ago

Since no longer repro'ing, closing now. Please reopen if this reoccurs.

lucyzhang929 commented 2 years ago

I am able to repro this issue on Windows ADS Stable and Insiders. There are no errors in my console logs.

Steps:

  1. Open ADS

  2. Open Add Remote Book wizard from Notebook View Toolbar

    Screen Shot 2022-06-09 at 12 23 11 PM

  3. Click Search

  4. Choose first option for all dropdowns Add button remains greyed out.