search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.56k stars 898 forks source link

A11y_AzureDataStudioAAE_PG1_Compute + Storage_Keyboard: "Save" & "Discard" button are not getting the instant keyboard focus after updating the edit fields. #15759

Closed krrish2021 closed 2 years ago

krrish2021 commented 3 years ago

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_AzureDataStudio_AAE_Jun2021;#SQL Azure Data Studio;#Win10;#FTP;#DesktopApp;#Keyboard;#WCAG2.4.3;#AINotInScope;

Environment Details:

Application Name: Azure Data Studio - AAE Windows Version: Win10

Repro Steps:

  1. Launch the application-Azure Data Studio-Insiders and install extension Azure arc and Azure data ClI
  2. Connect to Azure Arc Controller
  3. Tab till Azure Arc Controller tree and tab to the node present under it
  4. Tab to child node "PG1" and open manage and tab to "Compute + Storage" page
  5. Edit any Spin button and tab to save button

Actual:

"Save" & "Discard" button are not getting the instant keyboard focus after updating the edit fields.

Expected:

"Save" & "Discard" button should get the instant keyboard focus after updating the edit fields.

User Impact:

Keyboard users will get confused if the button do not focus in logical sequenced order.

https://user-images.githubusercontent.com/85863543/127598602-26f4264d-541c-4640-b057-b7d14f05582a.mp4

nasc17 commented 3 years ago

Would like clarification on what should happen here.
Should the focus go to the buttons right after the user makes a change to any one text box? Couldn't that steal focus away in the middle of typing something or changing values? What if the user wanted to continue down the fields to edit instead of saving right away?

nasc17 commented 3 years ago

@krrish2021 Will be closing, please link to requirement for this issue and reopen.

krrish2021 commented 2 years ago

@nasc17 "Save" & "Discard" button should be present at the bottom of the page and not on top of the page so that after editing all the fields, the focus should shift to "Save" & "Discard" button. Please reopen the bug.

candiceye commented 2 years ago

@krrish2021 Closing this for now, as this Save button is present in other areas in ADS and have not been flagged before; could you please provide a link to the documentation/WCAG requirements for this issue?

alanrenmsft commented 2 years ago

@krrish2021 the location of the button shouldn't matter, right? for example, Outook, Word and even notepad, the actions/menus are all at the top of the UI.