Better formatting for generated T-SQL from Open API spec

[zijchen]

Current formatting when generating sqlproj from Open API spec:

CREATE TABLE [SwaggerPetstore.Models].[NewPet](
    [Id] [int] NOT NULL,
    [Name] [nvarchar](4000) NOT NULL,
    [Tag] [nvarchar](4000) NULL,
 CONSTRAINT [PK_NewPet] PRIMARY KEY CLUSTERED 
(
    [Id]
)
)

[zijchen]

Same table from extract:

CREATE TABLE [SwaggerPetstore.Models].[NewPet] (
    [Id]   INT             NOT NULL,
    [Name] NVARCHAR (4000) NOT NULL,
    [Tag]  NVARCHAR (4000) NULL,
    CONSTRAINT [PK_NewPet] PRIMARY KEY CLUSTERED ([Id] ASC)
);

[Benjin]

This is how SMO generates scripts

Options:

1. SMO scripting options to prettify it
2. scriptdom interpret -> generate
3. vscode format document

[Benjin]

It turns out that there's no SMO option for formatting output nicely, so the option 1 is out. 2 would involve adding a call to Tools Service to pipe the capability down to ScriptDom... maybe not worth it. I think 3 is a fine balance, and has the added bonus of using the language server to determine correctness, which is the future.

@zijchen thoughts?

[zijchen]

Yeah I agree. Option 2 is overkill unless we find other uses for ScriptDom. 3 sounds best to me

[udeeshagautam]

Closing as by design (from SMO) for now.