A11y_SQLMigrationControlPlane_ AzureSQLMigration _MigrationStatus_ScreenReader: Buttons present inside the table is announced as group by the screen reader.

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.

https://learn.microsoft.com/sql/azure-data-studio

MIT License

7.57k stars 901 forks source link

A11y_SQLMigrationControlPlane_ AzureSQLMigration _MigrationStatus_ScreenReader: Buttons present inside the table is announced as group by the screen reader. #20632

Closed BhanuPrakashGit closed 9 months ago

BhanuPrakashGit commented 2 years ago

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#AzureDataStudioextensionAzureSQLMigration-Mac-Sept2022;#SQL Migration Control Plane;#A11ySev2;#WCAG1.3.1;#DesktopApp;#Win11;#ScreenReader;#Benchmark;#VoiceOver;#Mac

Environment Details:

Azure Data Studio: Version: 1.39.1 Operating System: Mac Version 12.5.1 Screen reader: VoiceOver

Steps to Reproduce:

Install Azure data studio and open
Tab till Extension press enter key and install Azure SQL Migration
Tab till Respective server and right click
Tab till manage and press enter key
Tab till Azure SQL Migration and press enter key
Tab till migrate to azure sql and press enter key
Saved session page will open
Select start new session and give next
Databases for assessment page will open
Select the respective databases and give next
Assessment results and recommendations page will open
Select Azure SQL managed Instance /Virtual Machinesfrom Azure SQL Target
Tab till View/Select button, assessment results for '' dialog will open
Observe that keyboard focus is going over the non-interactive text.
Open Screen reader and observe that the buttons present on the table are announced as the group.

Actual:

Buttons present inside the table is announced as group by the screen reader.

Expected:

Buttons present inside the table should announced as button by the screen reader.

User Impact:

Screen reader users will get confused with the controls present on the screen. Screen Recording 2022-09-15 at 10.46.47 AM.zip

brian-harris commented 1 year ago

@aasimkhan30 is this issue fixed now?

aasimkhan30 commented 1 year ago

@brian-harris, yup it is fixed.

brian-harris commented 1 year ago

@BhanuPrakashGit, closing this bug as it should now be fixed, please reopen if not.

BhanuPrakashGit commented 1 year ago

Hi @brian-harris tried to verify the bug in the environment: Version: 1.47.0-insider (Universal) Commit: a63463e35bb21bb89250be09d9639ff440c83b39 Date: 2023-09-21T05:42:38.696Z VS Code: 1.79.2 Electron: 22.3.14 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.6.0

but getting below error, could you please look into this.

brian-harris commented 1 year ago

@BhanuPrakashGit can you try updating your insiders version to latest or install latest stable version of ADS if that doesn't unblock you.

BhanuPrakashGit commented 1 year ago

Hi @brian-harris, I downloaded the Azure Data Studio from the below link, https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

I got the same version as mentioned above and getting same error. Could you please look into this.

brian-harris commented 1 year ago

@BhanuPrakashGit , my team has created this suggestion to a similar issue. Can you see if this method works for you?

Azure Data Studio issues:
Failed to start Sql Migration Service: Error: Request error: Message: Error at ClientRequest. (c:\Users\et56892.azuredatastudio\extensions\microsoft.sql-migration-1.4.2\dist\main.js:2:7448) at ClientRequest.emit (node:events:538:35) at TLSSocket.socketOnEnd (node:_http_client:466:9) at TLSSocket.emit (node:events:538:35) at endReadableNT (node:internal/streams/readable:1345:12) at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
Cause: This happens when ADS is not able to download the MigrationService package from https://github.com/microsoft/sqltoolsservice/releases . The download failure can be due to disconnected network work or unresolved proxy settings. We are working on a fix. Recommendation :
The surefire way of solving this is by downloading the package manually. Follow the mitigation steps outlined in this link: https://github.com/microsoft/azuredatastudio/issues/22558#issuecomment-1496307891

BhanuPrakashGit commented 1 year ago

Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after bug verification.

Hi @brian-harris Tried the steps shared above but steps are not clear as in the first steps, it says to run command but terminal shows, there is no such command. Could you please share the clear steps so that I can verify this issue

brian-harris commented 1 year ago

re-opening bug as requested: Does this work for you? Open command pallet

Open extensions directory

Find sql-migration

BhanuPrakashGit commented 1 year ago

@brian-harris Yes, I'm able find this folder. What's the next steps? Please let me know.

brian-harris commented 1 year ago

please continue to follow these instructions:

BhanuPrakashGit commented 1 year ago

Hi @brian-harris I tried to verify the issue but I'm not able to require subscription name because of that I'm not able to proceed further. Could you please help me here

brian-harris commented 1 year ago

@BhanuPrakashGit can you please verify you have a SQL Managed Instance created in the One Integration Service subscription. The target selection page will only show locations and resource groups that contain a SQL Managed Instance. If there aren't any in the subscription, it will be blank.

brian-harris commented 1 year ago

This tutorial may be helpful: https://learn.microsoft.com/en-us/azure/dms/tutorial-sql-server-managed-instance-online-ads

BhanuPrakashGit commented 1 year ago

@brian-harris Earlier I got the access for the below subscription, but this is not available in the subscription field now.

brian-harris commented 12 months ago

@BhanuPrakashGit, you should now have access to the subscription, please try again.

BhanuPrakashGit commented 11 months ago

@brian-harris Tried to Verify in the server but getting below error, Could you please look into this. Seems provided server is not working anymore.

BhanuPrakashGit commented 11 months ago

Hi @brian-harris Below is the proxy configuration setting in ADS. Is it the right configuration? Please let me know

BhanuPrakashGit commented 11 months ago

@brian-harris Could you please confirm whether the UI for Migration status is changed, please find the screen shot below

MicrosoftTeams-image (34)

is this the latest screen for Migration status? Please confirm on this

brian-harris commented 11 months ago

This looks like the latest. Please ensure you have the latest update ADS and the SQL Migration extension:

BhanuPrakashGit commented 11 months ago

@brian-harris Tried to verify the bug in the environment: Version: 1.48.0-insider (Universal) Commit: e5e1204d4fb4d4e880cdd893347752ee5736459a Date: 2023-12-05T06:38:01.191Z VS Code: 1.82.0 Electron: 25.9.6 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0

I'm unable to verify the issue as screen reader focus is not going over the buttons 'DWQueue' and 'Restoring'. Could you please look into this. Please find the attachment

20632_Not Fixed.zip

cpichuka commented 11 months ago

Tagging @krritik for this bug. @BhanuPrakashGit , please tag Ritik from now on wards

krritik commented 10 months ago

Focus of sequential keyboard navigation (e.g., pressing the "Tab" key) is not going over the hyperlinks in the table component row elements.

Issue is that tabIndex is set as -1 by default for hyperlink elements in table component. It should be 0, then only sequential focus will work. We are using azdata.TableComponent for table and for hyperlink table components, we are using azdata.HyperlinkColumnCellValue.

The bug is on ADS core team. @alanrenmsft @aasimkhan30

CC @cpichuka

cpichuka commented 10 months ago

@BhanuPrakashGit , did you log bug for ADS?

BhanuPrakashGit commented 10 months ago

Githubtags:#Regressed:12-27-23;#External;#External:ADS;#FirstParty:Bug25150 Logged External bug: https://github.com/microsoft/azuredatastudio/issues/25150#issue-2057171925

As per the C & AI bug process assigning the bug to the Product Owner. Please assign this bug back to the tester once the "External" issue has been resolved and changes are pushed to the environment that will be available for bug verification.

alanrenmsft commented 10 months ago

@kisantia fyi.

kisantia commented 10 months ago

@BhanuPrakashGit I commented on the created issue that the attachment is empty. Table navigation is expected to be done using arrow keys. Are those buttons in the table not accessible with arrow keys?

It is by design that button and checkbox columns have tabindex=-1 because the tab key is used for entering and exiting the table, and tab keys are meant for navigating within the table.

BhanuPrakashGit commented 9 months ago

GithubTags:#Regressed:01-15-24;#Closed; Verified the bug in the environment: Version: 1.48.0-insider (Universal) Commit: https://github.com/microsoft/azuredatastudio/commit/e5e1204d4fb4d4e880cdd893347752ee5736459a Date: 2023-12-05T06:38:01.191Z VS Code: 1.82.0 Electron: 25.9.6 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.2.0

Issue is fixed, we are able to navigate over the button with the help of the arrow keys and voiceover announcing it as button. Hence closing the bug. PFA for reference

25150_FocusIssue.zip