microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.54k stars 898 forks source link

Publish scripts failing with standard error due to a debug warning #22964

Open cheenamalhotra opened 1 year ago

cheenamalhotra commented 1 year ago

Below warning is being captured when executing publish scripts, that leads to standard error:

2023-05-04T06:47:47.4753400Z ##[debug]STDERR: (node:6240) Warning: Accessing non-existent property 'zero' of module exports inside circular dependency
2023-05-04T06:47:47.4776072Z ##[debug]STDERR: (Use `node --trace-warnings ...` to show where the warning was created)
2023-05-04T06:47:47.5153737Z ##[error](node:6240) Warning: Accessing non-existent property 'zero' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
2023-05-04T06:47:47.5162169Z ##[debug]Processed: ##vso[task.logissue type=error](node:6240) Warning: Accessing non-existent property 'zero' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
2023-05-04T06:47:47.5168182Z Size: 197801356

This is happening when below code is being executed: https://github.com/microsoft/azuredatastudio/blob/8a56e0c0cd3d718ad12cce02d46a6f9512765a67/build/azure-pipelines/common/publish.js#L139-L140

Started with PR: #22811 Targeted to be fixed by next release.

kburtram commented 1 year ago

As far as I understand this is not associated with plan source code changes in the May release branch. I thought this was to track reenabling the "Fail on console.error" output in the build. If my understanding is correct, I've moved to July to track. If there is a port request planned for this please move back into May release milestone. Thanks!

cheenamalhotra commented 1 year ago

I'll pick it up post July release to see if the recent merge solved it or it continues to occur.