search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 901 forks source link

Dropdown onValueChanged event not firing #24060

Open smartura opened 1 year ago

smartura commented 1 year ago

I work on the team that maintains the SQL Migration extension for ADS. During testing I believe I have found an issue with dropdown boxes.

Link to an example: https://github.com/microsoft/azuredatastudio/blob/e0120356cb9b7bd0bfaf8fc0766455ce5215ae5d/extensions/sql-migration/src/wizard/targetSelectionPage.ts#L288-L297

On line 288, we clear the accounts dropdown. On line 297, we repopulate the accounts dropdown.

The corresponding event on line 328 never fires: https://github.com/microsoft/azuredatastudio/blob/e0120356cb9b7bd0bfaf8fc0766455ce5215ae5d/extensions/sql-migration/src/wizard/targetSelectionPage.ts#L328-L333

Does this issue occur when all extensions are disabled?: Yes/No

cheenamalhotra commented 1 year ago

Figured this is where the event gets rejected, which seems by design.

image

The event triggers as expected when user selects a value.

cheenamalhotra commented 1 year ago

I'll see what we can do here, to provide an option to trigger selection events. Keeping issue open till then.