microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.56k stars 898 forks source link

A11y_Azure Data Studio_Nov2023_Database Properties Preview_Files_Keyboard: When navigating to under the Files tab "Database files" grid column headers are not accessible with any keyboard keys. #25208

Closed Raj-ghuge closed 7 months ago

Raj-ghuge commented 9 months ago

"Please do not close this bug. This bug should only be closed by Trusted Tester after verification."

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.

GitHub Tags:

A11yTCS; #A11yMAS; #A11ySev1; #DesktopApp; #WCAG2.1.1; #FTP; #SH_Azure Data Studio_Nov2023_Linux_Dec2023; #SQL Azure Data Studio; #Linux; #Keyboard;

Environment Details:

Application Name: Azure Data Studio OS Name: Ubuntu 22.04.2 LTS Azure data studio 1.47.0

Repro Steps:

  1. Install Azure data studio application and open it
  2. Make sure to enable "Preview" feature in settings.
  3. Navigate by using TAB key till "Database" and press enter to expand the tree.
  4. Navigate by using TAB key till any database and pressF10 to open context menu.
  5. Navigate by using TAB key till "Properties Preview" and press enter.
  6. Navigate by using TAB key till "Files" tab and press enter.
  7. Navigate by using TAB key till "Database files" table and try to change column size.
  8. Observe that, unable to change column size with keyboard keys.

Actual results:

When navigating to under the Files tab "Database files" grid column headers are not accessible with any keyboard keys. Note: Issue seen throughout the application for similar type control.

Expected results:

When navigating to Files "Database files" grid column headers should be accessible with keyboard & also should be able to adjust the column header with keyboard.

User Impact:

Keyboard only users will face difficulties if the focus does not go to column header and cannot resize the column header.

Attachments:

25208.zip

corivera commented 9 months ago

@Raj-ghuge This is a duplicate of another accessibility issue here: https://github.com/microsoft/azuredatastudio/issues/25132

Raj-ghuge commented 9 months ago

@corivera https://github.com/microsoft/azuredatastudio/issues/25132 the bug is on Win32 platform and above bug is of Linux.

corivera commented 9 months ago

@Raj-ghuge resizing columns is provided via the keyboard shortcut Shift+Alt+S

corivera commented 8 months ago

@Raj-ghuge Can you verify that the issue is fixed using that shortcut? You can find the latest Ubuntu build of ADS here.

Raj-ghuge commented 8 months ago

@corivera Verified the issue in the environment - Application Name: Azure Data Studio OS Name: Ubuntu 22.04.2 LTS Azure data studio 1.47.0 The keyboard shortcut Shift+Alt+S is not working for "Database files" grid table not working. Please find attachment-

https://github.com/microsoft/azuredatastudio/assets/130441232/4f1808d6-089b-47a9-9065-a0608204c46b

kisantia commented 7 months ago

@Raj-ghuge the keyboard shortcut might be slightly different on linux. To find the key mapping

  1. open the command palette (View->Command Palette): image

  2. Type "keyboard shortcut" and select "Preferences: Open Keyboard Shortcuts" image

  3. Search for "grid.resizeColumn" and see the shortcut (ex: on my mac, it shows shift+option+s): image

corivera commented 7 months ago

@Raj-ghuge what's not working here? I saw the size prompt popped up at the top of the ADS window in your video clip. The column size is set there and then after hitting Enter the new size is applied to the column.

Raj-ghuge commented 7 months ago

Verified the issue in the environment - Application Name: Azure Data Studio OS Name: Ubuntu 22.04.2 LTS Azure data studio 1.49.0 The issue is fixed, hence closing the bug. Please find attachment.

Closed;

Regressed:03-14-24

https://github.com/microsoft/azuredatastudio/assets/130441232/05fdfc27-e045-4036-ac75-dc451ac2d5ed