search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

Fix SQL version determination logic for Fabric DW #25812

Closed zijchen closed 3 months ago

zijchen commented 3 months ago

The mssql API returns the engine edition to be 5 (SqlDatabase) for Fabric DW, which might be a bug in itself. Since the server name check would only be applicable to the 2 valid Fabric DW domain, this change should be fine.

Fixes #25811

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10276223911

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/common/utils.ts 0 8 0.0%
<!-- Total: 0 8 0.0% -->
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 45.22%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 10207294964: -0.002%
Covered Lines: 30728
Relevant Lines: 68919
💛 - Coveralls