search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.59k stars 909 forks source link

Displaying non-default columns for local .xel files #25907

Closed glaubercini closed 2 months ago

glaubercini commented 2 months ago

A .xel file produced outside of SQL Server may contain a different set of columns. Since Azure Data Studio's SQL Server Profiler has its own set of display columns, these non-default ones are simply ignored.

This PR adds support for displaying non-default columns in the details section while preserving the default behavior that fixes #25906 issue.

Before: before

After: after

SakshiS-harma commented 2 months ago

Hey @glaubercini, it was great working with you for this bug+fix. Do you mind adding a snippet of before (how the data wasn't visible on UI in ADS, but it was presented in SSMS) and after (data presented in ADS as well)? Changes look good to me :shipit: . May be just wait for another reviewer to approve before merging your changes

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10818236217

Details

Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 10777409214: -0.003%
Covered Lines: 30728
Relevant Lines: 68921
💛 - Coveralls