search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

Adding validations for change in aad and logins after a successful validation #25945

Closed Bhavikshah123 closed 1 month ago

Bhavikshah123 commented 1 month ago

This PR takes care of 2 more validation scenarios

  1. Cx succesfully validates with a set of logins , and now cx selects a new login and proceed for migration without validation. We shouldn't allow this image

  2. Cx selects a windows login, successfully validates it, but now changes the entra. We shouldn't allow this image

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11138352690

Details

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 45.22%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 11090570810: -0.008%
Covered Lines: 30726
Relevant Lines: 68916
💛 - Coveralls