microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

Making user mapping optional, Adding telemetry and string changes #25954

Closed Bhavikshah123 closed 1 month ago

Bhavikshah123 commented 1 month ago

This PR takes care of the following -

  1. Make user mapping optional as per discussion, don't want the cx to migrate databases just because logins associated with it cannot be migrated. So making it optional.
  2. Added newlines between errors displayed in validation status box
  3. Added LoginMigrationPreValidationStarted, LoginMigrationPreValidationSuccessful, LoginMigrationPreValidationFailed
  4. String changes

image

  1. Modified AAD domain errors to Entra Errors by consuming new login nuget having the changes image image
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11248941761

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 11185654865: 0.02%
Covered Lines: 30730
Relevant Lines: 68916

💛 - Coveralls