microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

Added Telemetry and fixed Template Upload error #25991

Closed sahuroshan closed 3 weeks ago

sahuroshan commented 1 month ago

This PR fixes 3 things.

  1. Added Telemetry for Target provisioning.

  2. Instead of pasing skurecommendation file path , now we are passing just target type to the getarmtemplate API in toolsservice.

  3. There was an intermitent issue while uploading ARM templates , the upload was failing sometimes. To fix this we are now generating Account SAS , earlier we were generating container SAS. This was problem with azure/storage-blob node module. Found similar isue here - https://learn.microsoft.com/en-us/answers/questions/334786/azure-blob-storage-fails-to-authenticate-make-sure image

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11504358086

Details


Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 11467144417: -0.001%
Covered Lines: 30719
Relevant Lines: 68916

💛 - Coveralls
sahuroshan commented 4 weeks ago

HAs this been tested in all platforms?

yes working on mac,windows,linux.