Closed sahuroshan closed 3 weeks ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts | 1 | 73.44% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 11467144417: | -0.001% |
Covered Lines: | 30719 |
Relevant Lines: | 68916 |
HAs this been tested in all platforms?
yes working on mac,windows,linux.
This PR fixes 3 things.
Added Telemetry for Target provisioning.
Instead of pasing skurecommendation file path , now we are passing just target type to the getarmtemplate API in toolsservice.
There was an intermitent issue while uploading ARM templates , the upload was failing sometimes. To fix this we are now generating Account SAS , earlier we were generating container SAS. This was problem with azure/storage-blob node module. Found similar isue here - https://learn.microsoft.com/en-us/answers/questions/334786/azure-blob-storage-fails-to-authenticate-make-sure