microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

Fix a bug in my last PR #26053

Closed zijchen closed 1 week ago

zijchen commented 1 week ago

I originally had this line in there, but I changed it to the one in #26049 thinking it's more readable, but they're not the same as now this becomes undefined in the callback. Apparently in JS, passing function directly as argument binds it to a specific object instance, but using "lambda" functions doesn't. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11808342124

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/controllers/projectController.ts 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 11807843306: -0.003%
Covered Lines: 30722
Relevant Lines: 68916

💛 - Coveralls