search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.58k stars 908 forks source link

[Port to release/1.50] Fix target platform when creating project from database via quickpick #26054

Closed zijchen closed 1 week ago

zijchen commented 1 week ago

Fixes #26052

Porting #26049 and #26053

When creating a project from database via VS Code quickpick, the connection data is never passed to the controller, so it always defaulted to 160/Sql2022 target platform in the sqlproj. There used to be an option to create project from right clicking on a database in mssql, but it was removed at some point, making quickpick the only option. This PR fixes the code path via quickpick by passing the create project function as a callback.

kburtram commented 1 week ago

@zijchen could you please resolve the merge conflict for this PR? Thanks!

zijchen commented 1 week ago

@kburtram it should be resolved now