search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.53k stars 896 forks source link

DacFx shows different result of schema compare() and apply() for some options #5599

Closed udeeshagautam closed 4 years ago

udeeshagautam commented 5 years ago

Azure Data Studio Version: Dev Build / Insiders Separating from review tasks #5481 for separate tracking

Steps to Reproduce:

  1. Do a schema compare such that that you have deletes
  2. Check in options that Drop objects not in source is set to false
  3. Re-compare
  4. The deletes still show
  5. Generate script (or apply)
  6. Deletes are not scripted (or applied)

Temporary fix - change some default options to what is respected in DacFx so that the UX reflects what is actually getting deployed at least in default cases. This makes it behave same as SSDT for most cases.

Long term - the real long term fix is to fix the DacFx Schema compare API to reprect these options in compare and generate script the same way.

udeeshagautam commented 4 years ago

Closing this since this should be fixed post changing the default options and making sure the exclude include is blocked if not really possible. Will reactivate if this is seen again.