search

microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.54k stars 898 forks source link

UI in Windows is dim in HDR mode #8058

Open SidShetye opened 4 years ago

SidShetye commented 4 years ago

Azure Data Studio Version:

Version: 1.12.2 (user setup) Commit: c9bef82ace6c67190d0e83820011a2bbd1f793c1 Date: 2019-10-11T04:56:40.634Z VS Code 1.37.0 Electron: 4.2.9 Chrome: 69.0.3497.128 Node.js: 10.11.0 V8: 6.9.427.31-electron.0 OS: Windows_NT x64 10.0.18362

Likely issue

This is likely an issue because you are using electron v4. The same issue was reported in VSCode (here) and the fix is to upgrade to electron 6.

Steps to Reproduce:

  1. Enable HDR in Windows 10
  2. Launch ADS
  3. Struggle to see UI

Screenshot

The left side is ADS and the right side is SSMS.

ADS-dim-ui

SidShetye commented 4 years ago

Temporary workaround is to launch with --force-color-profile srgb

If you installed ADS using the standard installer

  1. Go to C:\Users\<username>\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Azure Data Studio
  2. Right click the Azure Data Studio shortcut -> properties -> shortcut tab -> target
  3. "C:\Users\<username>\AppData\Local\Programs\Azure Data Studio\azuredatastudio.exe" --force-color-profile srgb
  4. Ok
kburtram commented 4 years ago

@SidShetye we'll be updating to Electron 6 in December release. I think that insider builds already have this update.

ghost commented 4 years ago

I had this same issue and like in previous threads it gets fixed with --force-color-profile srgb. It'd be nice if this wouldn't happen. It was working properly until some random Windows' window manager glitch with HDR over DisplayPort (everything gets dim and you've gotta kill dmw.exe to get it back to normal), and then VS Code stayed dim, even after a computer restart. Other apps that were dimmed as well got fixed by just restarting them. VS Code 1.43 Windows 10.0.18363

domenic commented 4 years ago

I am also experiencing this in 1.43. My situation sounds very similar to @feniworks; I was messing around with surround display and color profiles yesterday, and it seems to have uniquely messed up VS Code, with all other apps recovering.

FreekVR commented 4 years ago

Seems to have broken in the latest 1.43.0-release for me too, before clicking the "restart to update" it was fine.

platten commented 4 years ago

I'm still having this issue in 1.33.0-insider, which is using electron 7.1.11. --force-color-profile srgb works as a workaround (though it would be preferable to not have to use it, or have a setting).

ChipWolf commented 4 years ago

Same here

Funnily enough the brightness of the window looks fine if I'm in the process of selecting an area for a screenshot with ShareX.

Update: I have found a fix!

Open the command palette and go to Preferences: Configure Runtime Arguments. From here, look for the setting "disable-color-correct-rendering": true. Change it from true to false. Restart Visual Studio Code.

kaneorotar commented 4 years ago

Same here on VSCodium 1.44

Version: 1.44.0 Commit: 2aae1f26c72891c399f860409176fe435a154b13 Date: 2020-04-09T10:22:06.688Z Electron: 7.1.11 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

tuananh commented 4 years ago

still have this problem on insider build 

Version: 1.45.0-insider (user setup)
Commit: ece7aaee861d7261a728d52ce436c667030ce17d
Date: 2020-05-01T09:46:47.589Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19619
rtheil commented 4 years ago

Also having this issue. Claimed to be fixed in Electron 6, but I upgraded to 9.0.4 and no difference, even though config doesn't show 9.0.4. Only happens when HDR enabled on monitor.

Version: 1.46.1 (user setup) Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d Date: 2020-06-17T21:13:20.174Z Electron: 7.3.1 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

vladimir-novoseltsev commented 4 years ago

Same problem on latest VS Code, adding in launcher "--force-color-profile srgb" seem to fix the problem. Is it possible to make it configurable option from VSCode, or somewhere else to enable globally for all instances, not just the one launched with shortcut?

vladimir-novoseltsev commented 4 years ago

Never mind, found it. The property could be set globally in "Preferences: Configure Runtime Arguments".

GizzmoAsus commented 4 years ago

Same on the below version:

Version: 1.47.2 (system setup) Commit: 17299e413d5590b14ab0340ea477cdd86ff13daf Date: 2020-07-15T18:22:06.216Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Resolved by following https://github.com/microsoft/azuredatastudio/issues/8058#issuecomment-612907109 👍

jdelforno commented 4 years ago

Version: 1.47.2 (user setup) Commit: 17299e413d5590b14ab0340ea477cdd86ff13daf Date: 2020-07-15T18:22:06.216Z (1 wk ago) Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.19041

Opened "Preferences: Configure Runtime Arguments" Set: "disable-color-correct-rendering": false

Fixed it.