microsoft / azuredatastudio

Azure Data Studio is a data management and development tool with connectivity to popular cloud and on-premises databases. Azure Data Studio supports Windows, macOS, and Linux, with immediate capability to connect to Azure SQL and SQL Server. Browse the extension library for more database support options including MySQL, PostgreSQL, and MongoDB.
https://learn.microsoft.com/sql/azure-data-studio
MIT License
7.54k stars 898 forks source link

Agent steps don't change status based on current select job run #9152

Closed Tarig0 closed 4 years ago

Tarig0 commented 4 years ago

Steps to Reproduce:

  1. Have a job run fail
  2. Open the job to view details
  3. Select previous run

See steps area not updated

adsbot[bot] commented 4 years ago

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

abist commented 4 years ago

Fixed by https://github.com/microsoft/sqltoolsservice/pull/922

Tarig0 commented 4 years ago

Still an issue, job step messages retain the first runs step information

Version: 1.16.0-insider (user setup) Commit: 4c3d51aa52f5f531b1004f84f000a7eca37161cd Date: 2020-03-02T06:27:05.758Z VS Code: 1.42.0 Electron: 7.1.11 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Tarig0 commented 4 years ago

Please re-open this

Charles-Gagnon commented 4 years ago

@Tarig0 This change hasn't made it to ADS yet - I'll get a PR out to update the tools service now after which this should be resolved.

Charles-Gagnon commented 4 years ago

@abist Turns out we did actually update the tools service so your fix is in the current insiders release. Please investigate when you get a chance.

Tarig0 commented 4 years ago

Step messages update; status badge next to it does not.

image

Version: 1.16.0-insider (user setup) Commit: 34a7340a18cfb298679ff37dc7297f373e7ffa3f Date: 2020-03-06T05:55:34.896Z VS Code: 1.42.0 Electron: 7.1.11 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0.18363

Charles-Gagnon commented 4 years ago

@abist - Please look into that when you get a chance