microsoft / azurelinux

Linux OS for Azure 1P services and edge appliances
MIT License
4.08k stars 497 forks source link

Deprecate old read-only root support. #9537

Closed dmcilvaney closed 5 days ago

dmcilvaney commented 5 days ago
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)


Summary

The new grub flow does not play well with our old dm-verity implementation. The ImageCustomizer tool supports creating verity images now, so lets just get rid of the old verity.

When we first added ReadOnlyVerityRoot to the config for Mariner 1.0 there was no support for dm-verity in systemd or dracut so we needed to build a custom solution. Those components now natively support dm-verity, so let's not re-invent the wheel.

For 3.0 GA just disable the config, a full clean-up can come after GA since we will have to roll back large parts of https://github.com/microsoft/azurelinux/pull/549 (72 files). Cleanup shouldn't be hard but it's a big bit of code to drop right before GA.

Change Log
Does this affect the toolchain?

NO

Associated issues
Test Methodology
dmcilvaney commented 5 days ago

Can't say much if anyone is expecting to still use it, but if it's out before 3.0 GA, then I guess it's OK.

The code changes look good to me. I love removing code.:)

EFLOW does, but I've already reached out. MIC should be a reasonable replacement.