[HOUSEKEEPING] Removing variable-group create

[andrebriggs]

Update removing variable-group create

Noticed that we don't have an example for how to use variable-group create in our first class documentation.

Also this method is referenced in current issue and it needs unit tests.

Also looking for feedback on if this method should even exist. It seems to be a wrapper for az pipelines variable-group create. Trying to understand the value if we don't support replacement of secret values in the --file arg.

---

Also closes https://github.com/microsoft/bedrock/issues/1349

[mtarng]

I'm also curious about the spk variable-group create command. Are we using it anywhere in our documentation? I had thought this was a holdover from either infrastructure or introspection stuff. It's not currently being utilized by the service workflow, but we may look to leverage it with this issue: https://github.com/microsoft/bedrock/issues/1006. If we do, should we combine it with spk project create-variable-group ?

@yradsmikham @NathanielRose @samiyaakhtar @sarath-p @bnookala @evanlouie

[yradsmikham]

@mtarng , I confirmed with @sarath-p a while back, and I do not believe we are utilizing spk variable-group create.

[dennisseah]

@mtarng , I confirmed with @sarath-p a while back, and I do not believe we are utilizing spk variable-group create.

I also get the same answer when I was refactoring the code. there is already another one under spk project. And he mentioned that we can combine them. However no actions are taken.

[NathanielRose]

I'm also curious about the spk variable-group create command. Are we using it anywhere in our documentation? I had thought this was a holdover from either infrastructure or introspection stuff. It's not currently being utilized by the service workflow, but we may look to leverage it with this issue: microsoft/bedrock#1006. If we do, should we combine it with spk project create-variable-group ?

@yradsmikham @NathanielRose @samiyaakhtar @sarath-p @bnookala @evanlouie

We mention how to use it in some of our infra documentation: https://github.com/microsoft/bedrock-cli/blob/master/guides/infra/spk-infra-generation-pipeline.md#31a-create-a-variable-group

But we don't use the command in any of our infra functions or pipelines

[sarath-p]

@mtarng , I confirmed with @sarath-p a while back, and I do not believe we are utilizing spk variable-group create.

@yradsmikham and I discussed recently and concluded that issue https://github.com/microsoft/bedrock/issues/1006 can use az pipeline command instead of spk variable-group create if Key Vault linking is not required.

@andrebriggs - the spk variable-group create uses Azdo API directly and does not depend on az pipeline command since it doesn't support Key Vault linking which is not used in the project. I think it is safe to remove the command.

[andrebriggs]

In the service introspection guide we tell customers to use variable-group create.

@samiyaakhtar Is this incorrect?

Recently I added some scripts to deploy the dashboard and included a file to push variables to a variable group. I guess I could have used SPK for this.

[samiyaakhtar]

In the service introspection guide we tell customers to use variable-group create.

@andrebriggs this is old, we need to update that doc and reference the new variable group command, since we don't need to use keyvault

[sarath-p]

Recently I added some scripts to deploy the dashboard and included a file to push variables to a variable group. I guess I could have used SPK for this.

Yes, SPK can be used here. Its is a two step process to add secret variables using az pipeline as you did in the scripts.