mtarng commented 4 years ago

As a: spk user I want: spk generated artifacts to be pinned/versioned, where possible So that: I can ensure future stability if I use a version of spk that has been "certified" Describe the solution you'd like: Find out what dependencies spk and its workflow depends on (spk version in pipelines, fabrikate, helm, git, pipelines, azdo rest api, azdo node api, az cli etc.) and find out what versions we can control and find a way to set and pin versions on the consuming artifacts.

Acceptance Criteria:

[ ] spk command checks version on its dependencies (git, az cli versions)
[ ] spk artifacts require/set their own version that have been verified to work

Describe alternatives you've considered:

Additional context:

1171 #1182 were caused by azdo updating the build agent's default helm version.

Adding version for bedrock.yaml: https://github.com/microsoft/bedrock/issues/1082 Adding version for pipelines: https://github.com/microsoft/bedrock/issues/1144

Does this require updates to documentation?: Yes, especially on releases

mtarng commented 4 years ago

Perhaps this would work better as an epic with the two AC's assigned out to specific issues.

Pending input from all areas: infra, introspection, services.

@andrebriggs this issue was created based on feedback from @mzilberman

mtarng commented 4 years ago

Converting to bug and adding high priority. We've had users impacted by changes coming from outside of spk and bedrock. We should address this to prevent this from happening as soon as possible.

andrebriggs commented 4 years ago

microsoft / bedrock

Pin SPK dependencies #1184

1171 #1182 were caused by azdo updating the build agent's default helm version.