microsoft / bedrock

Automation for Production Kubernetes Clusters with a GitOps Workflow
MIT License
129 stars 12 forks source link

Better support for HLD only changes in Spektate dashboard #1372

Closed andrebriggs closed 4 years ago

andrebriggs commented 4 years ago

Currently the Spektate dashboard displays a row with empty values for service, ring, SRC to ACR, ACR to HLD, Approved Pull Request, and Merged By columns for changes that are made only in the HLD repository.

With the Bedrock CLI there is a feature for reconciliation that will trigger pipeline runs that modify the HLD repo.

The current behavior of Spektate doesn't make it obvious that this row (circled in screenshot) is a change to the HLD associated with a service.

This can also happen with some makes one off changes to the HLD repo for any over modifications (e.g. hand tweaked configuration changes).

The current experience is that you get a row that is mostly empty and breaks continuity in the dashboard results.

image

Some ideas:

As discussed in meeting 05/01:

samiyaakhtar commented 4 years ago

The changes needed to support better understanding of HLD change, as discussed in today's meeting: