microsoft / bedrock

Automation for Production Kubernetes Clusters with a GitOps Workflow
MIT License
129 stars 12 forks source link

Dashboard fails to load deployments when there are errors in author fetch call #1398

Closed samiyaakhtar closed 4 years ago

samiyaakhtar commented 4 years ago

Describe the bug: With the caching changes, author, pr and cluster sync endpoints are all fetched within a single api call. If there's a failure in one of them, it's causing the deployments to be returned [] instead of non-empty data in storage.

To Reproduce: Load dashboard for a configuration such as smoke test configuration which has a lot of deleted data from AzDO

Expected behavior: Dashboard should load as expected, if some api calls fail, such as author and pr, the cells should show empty but deployments should still be visible

Screenshots: image (2)

On viewing the logs in server: Screen Shot 2020-04-29 at 4 18 31 PM

Additional context:

Does this require updates to documentation?: