microsoft / bedrock

Automation for Production Kubernetes Clusters with a GitOps Workflow
MIT License
130 stars 12 forks source link

Update aks module to output identities #1442

Closed jpflueger closed 3 years ago

jpflueger commented 3 years ago

These changes use the azurerm_kubernetes_cluster resource's attributes as outputs instead of using the azure cli to get the desired outputs. It also exports the oms_agent_identity which will be required for a future improvement to the use of managed identity.

Issue: #1441

cc: @andrebriggs @jmspring

jpflueger commented 3 years ago

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

jmspring commented 3 years ago

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

It looks like the automated tests may be hung, let me see what I can do about that.

jmspring commented 3 years ago

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

It looks like the automated tests may be hung, let me see what I can do about that.

@jpflueger - did you try running the tests in bedrock/tests? The pipeline seems hung, I will take look when I get a chance.

andrebriggs commented 3 years ago

/AzurePipelines run

jpflueger commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago
Commenter does not have sufficient privileges for PR 1442 in repo microsoft/bedrock
azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).