Manifest diff as a PR comment for AzDO

microsoft / bedrock

Automation for Production Kubernetes Clusters with a GitOps Workflow

MIT License

130 stars 12 forks source link

Manifest diff as a PR comment for AzDO #1455

Open samiyaakhtar opened 3 years ago

samiyaakhtar commented 3 years ago

Added a helper function to the AzDO script to generate manifests and post a diff as a comment - see here for an example
Fixed a minor bug where downloading fabrikate would get into infinite loop when there's another downloaded archive from a previous job with the same name. Using a random uuid fixes this issue
Adding -q to silence the wget output which was taking up 90% of the output in logs, making it difficult to focus on the important logs generated by the scripts

samiyaakhtar commented 3 years ago

@nmiodice I'm unable to request a review from you for some reason, but feel free to give any feedback here, I followed your template for Gitlab :)

nmiodice commented 3 years ago

@nmiodice I'm unable to request a review from you for some reason, but feel free to give any feedback here, I followed your template for Gitlab :)

Hey! I'm not a maintainer for this project so I won't be able to give a formal review on this. Looks like you got some feedback from the maintaining team, though. Happy to help if I can!

andrebriggs commented 3 years ago

It would be good too see a larger diff so we can see what the user experience is like for large yaml diffs and (additions/subtraction)

samiyaakhtar commented 3 years ago

Based on discussion with @andrebriggs, converting this to a draft and after testing with larger diffs, we will re-open this