Open navzam opened 4 years ago
Moving to the backlog, it is a good request but we need more time to come up with a solution, we won't be able to address it as part of R11.
@darrenj this is an old feature request. Could you please triage and prioritize?
Is your feature request related to a problem? Please describe.
OAuthPrompt
allows you to use a custom activity as the prompt by passing inPromptOptions.Prompt
. But if you don't pass in an activity with aSigninCard
orOAuthCard
attachment, thenOAuthPrompt
injects its own card depending on the channel.This causes issues if you want to prompt with a different type of card, such as an adaptive card. For example on Teams if I pass an activity with an adaptive card,
OAuthPrompt
also injects aSigninCard
, resulting in a bad user experience.Describe the solution you'd like I want to be able to give
OAuthPrompt
any kind of activity/cards for prompting. Maybe a way to tell it "I'm providing my own prompt, don't mess with my attachments."Describe alternatives you've considered
OAuthPrompt
send just the sign-in button as a separate activityOAuthPrompt
won't send the button if there's already a user token. We also have to figure out whether or not to send our adaptive card with an additional user token check.SigninCard
andOAuthCard
(assuming we don't ever want to use those cards)OAuthPrompt
does unnecessary work to create its card, including (I think) HTTP callsOAuthPrompt
that overridesBeginDialogAsync
to 1) inject a dummySigninCard
to preventOAuthPrompt
from doing extra work, and 2) set anOnSendActivities
handler to remove the outgoingSigninCard
, before calling the baseBeginDialogAsync
.[enhancement]