microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 482 forks source link

OAuthPrompt forces use of OAuthCard/SigninCard, which limits auth UX #3644

Open navzam opened 4 years ago

navzam commented 4 years ago

Is your feature request related to a problem? Please describe. OAuthPrompt allows you to use a custom activity as the prompt by passing in PromptOptions.Prompt. But if you don't pass in an activity with a SigninCard or OAuthCard attachment, then OAuthPrompt injects its own card depending on the channel.

This causes issues if you want to prompt with a different type of card, such as an adaptive card. For example on Teams if I pass an activity with an adaptive card, OAuthPrompt also injects a SigninCard, resulting in a bad user experience.

Describe the solution you'd like I want to be able to give OAuthPrompt any kind of activity/cards for prompting. Maybe a way to tell it "I'm providing my own prompt, don't mess with my attachments."

Describe alternatives you've considered

[enhancement]

gabog commented 4 years ago

Moving to the backlog, it is a good request but we need more time to come up with a solution, we won't be able to address it as part of R11.

mrivera-ms commented 4 years ago

@darrenj this is an old feature request. Could you please triage and prioritize?