search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
873 stars 483 forks source link

Missing docs on enabling OAuth for bot in non-public azure #4924

Closed swagatmishra2007 closed 3 years ago

swagatmishra2007 commented 4 years ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

What package version of the SDK are you using. N/A

Describe the bug

Give a clear and concise description of what the bug is. For a bot to use OAuthPrompt in non-public azure clouds (like gov ), the following lines of code need to be added for a c# bot, startup.cs string uri = "https://api.botframework.azure.us"; MicrosoftAppCredentials.TrustServiceUrl(uri); OAuthClientConfig.OAuthEndpoint = uri; However, this is not documented at https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-authentication?view=azure-bot-service-4.0&tabs=aadv2%2Ccsharp and hence a bot developer would not know how to configure OAuth for a non-public cloud bot.

Expected behavior

Give a clear and concise description of what you expected to happen. The docs at the above link should be updated with these steps, so as to guide a bot developer in this scenario

JonathanFingold commented 3 years ago

Tracking in bot-docs PR 1954, assigned to @mmiele.

mrivera-ms commented 3 years ago

@JonathanFingold is this on track for R12?

mmiele commented 3 years ago

These are the articles where we talk about private cloud as it applies to government cloud:

• Connect a bot to the Web Chat channel - Bot Service • Compliance in Azure Bot Service - Bot Service • Bot Framework Frequently Asked Questions Index - Bot Service • Bot Framework Ecosystem Frequently Asked Questions - Bot Service • Bot review guidelines - Bot Service

mrivera-ms commented 3 years ago

@JonathanFingold if the issue you linked (bot-docs PR 1954) is tracking this work. Do we need this issue? Should we close it as duplicate?

mmiele commented 3 years ago

@mrivera-ms Let's live this issue open because is linked by the bot-docs PR 1954 until some viable solution is found.

mrivera-ms commented 3 years ago

@mmiele, @JonathanFingold, is there an estimation of the time this will take to complete. Right now it is tagged as on target for R12. If it is not be done within the R12 timeframe, we need to move it out of the milestone.

mmiele commented 3 years ago

Related PR https://github.com/MicrosoftDocs/bot-docs-pr/pull/2585 ready to be merged.

JonathanFingold commented 3 years ago

@mrivera-ms With the caveat that the publishing pipeline has been down for over a week, but [in theory] scheduled to come back up today, we are on track.

mrivera-ms commented 3 years ago

@JonathanFingold, is this item complete? Please update status. Thank you.

mrivera-ms commented 3 years ago

@JonathanFingold, please update status. Thank you.

JonathanFingold commented 3 years ago

The fix is in place and live in the docs.