search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
873 stars 483 forks source link

[Testing skills everywhere] Twillio-sms channel doesn't work with skills #5161

Closed Virtual-Josh closed 2 years ago

Virtual-Josh commented 3 years ago

The twillio-sms channel does not work with skills. When the host tries to call the skill the skill throws back a 404.11 error. This specific error is a security request filtering check which disables double escaped requests. While you can work around this by adding a huge security hole by allowing double escaped requests, the channel has another blocking issue.

When the skill tries to send a response back to the host the skill throws a "NotFound" error in the connector. It appears to be the case that there's something is going on with the activity id and the double escaping. Here's the error:

error

I think the fix here should be on ABS to do some transmogrification of requests from twilio to not force the double escaping so it functions to our customers like all of the other channels. It seems wrong to tell our customers to write a bunch of special wrapper code, and introduce a security hole to get this channel to work.

mrivera-ms commented 3 years ago

Reviewed by the SDK team. Needs investigation.

tracyboehrer commented 2 years ago

We will not be addressing at the moment.