search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
873 stars 483 forks source link

Channels "enumeration" is out of date #5678

Closed JonathanFingold closed 2 years ago

JonathanFingold commented 3 years ago

Version

Parent issue https://github.com/microsoft/botframework-sdk/issues/6448

"main" (as of 6/15, 1:59 PM Pacific)

Describe the bug

libraries/Microsoft.Bot.Connector/Channels.cs is out of sync with Intercom:

  1. The new Outlook Actionable Messages channel is missing ("outlook").
  2. The entry for "twilio-sms" seems like it should be marked [Obsolete], as it appears to be an incorrect duplicate of the existing entry for Twillio ("sms"). (This is also in the JavaScript SDK.)

To Reproduce

Steps to reproduce the behavior:

  1. Open https://github.com/microsoft/botbuilder-dotnet/blob/baf78d01d4c0b8ddae2d117a52d2a4bca1479683/libraries/Microsoft.Bot.Connector/Channels.cs
  2. Error: notice that there's no entry for "outlook".
  3. Error: see there are entries for "sms" and "twilio-sms".

Expected behavior

The channels enumeration stays up to date with the channels on the Azure portal, at least for additions.

Additional context

The Outlook Actionable Messages channel is in early preview, but visible in Azure.

Other channels enumerated in Intercom that are not in .NET:

Note:

gabog commented 2 years ago

We should mark the ones that are deprecated as obsolete and add the missing ones in a future release.

sw-joelmut commented 2 years ago

Hi @JonathanFingold, we noticed there are a few channels in the enumeration list that are not in the Azure Portal's channels anymore. Should we also mark these as obsolete?

Thanks.