search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

Keep existing ClaimsIdentity when handling get request #6288

Closed xieofxie closed 2 years ago

xieofxie commented 2 years ago

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

Currently main branch

Describe the bug

When in websocket, if we had already set ClaimsIdentity in adapter, it will be overwritten here https://github.com/microsoft/botbuilder-dotnet/blob/57faec119171b6347ce60556f758fca5c8b536b3/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs#L320

To Reproduce

Steps to reproduce the behavior:

Expected behavior

Do not overwrite existing ClaimsIdentity. We could append new ones

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

breakingram commented 2 years ago

BotFrameworkHttpAdapter is deprecated, and this is resolved in CloudAdapter.