search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
878 stars 484 forks source link

applying BotMessageSerializerSettings.MaxDepth doesn't seem to work #6542

Closed johnataylor closed 2 years ago

johnataylor commented 2 years ago

Customer reports that they see "The reader’s MaxDepth of 64 has been exceeded." Using Botbuilder V4.17 with Newtonsoft.Json 13.0.1

Downgrading to Newtonsoft.Json to 12.0.3 resolved the issue. As described in https://github.com/microsoft/BotBuilder-Samples/issues/3328

However when they tried the settings as described in https://github.com/microsoft/BotFramework-Composer/issues/9387#issuecomment-1254199071

Using using Botbuilder V4.17 with Newtonsoft.Json 13.0.1 they tried to change the MaxDepth but this did not seem to work.

tdurnford commented 2 years ago

@JuanAr Can you investigate this issue?

JuanAr commented 2 years ago

@JuanAr Can you investigate this issue?

Hi @tdurnford, we'll add this issue to our backlog. We'll let you know as soon as we start investigating it. Thanks!

ceciliaavila commented 2 years ago

Hi @tracyboehrer, We reviewed the issue and the changes we made a few months ago, and we may have missed applying the MaxDepth setting in the OAuthClient class. Also, we need to check the ConnectorClient and TeamsConnectorClient classes, as we think there may be code paths that are not setting the property. If it's ok, we'll try to include this issue in this iteration, after finishing the CodeQL fixes.

462sai commented 2 years ago

Hi @ceciliaavila

Could you please confirm this fix is released? if yes please confirm the botbuilder version

Regards, Sai.

ceciliaavila commented 2 years ago

Hi @ceciliaavila

Could you please confirm this fix is released? if yes please confirm the botbuilder version

Regards, Sai.

Hi @462sai, this fix was merged but the version is still in preview.

Thanks,

tracyboehrer commented 2 years ago

@462sai This is not released. Rather just merged into main. The next release is currently scheduled for early January. However, there is a periodic development release to MyGet. Reference the "UsingMyGet.md" for details.