search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
865 stars 480 forks source link

Let the configuration keys be configurable #6669

Closed vbossica closed 1 year ago

vbossica commented 1 year ago

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe.

Configuration keys are hard-coded and are an issue when, for example, the password is stored in a Key Vault, when its name is not MicrosoftAppPassword

Describe the solution you'd like

Change the ConfigurationServiceClientCredentialFactory to make the configuration keys configurable.

Describe alternatives you've considered

Extending the class wouldn't work and it would be advantageous to keep the logic of this class intact.

anishprasad01 commented 1 year ago

Hi @vbossica,

Thank you for the suggestion. At this time, we are not planning to make this change in the SDK. However, you are of course completely free to modify and/or extend the framework as you see fit for your implementation.