#6673 - Fix of SNI auth not working in Cert based authentication

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

865 stars 480 forks source link

#6673 - Fix of SNI auth not working in Cert based authentication #6676

Closed mikeus-hanzlik closed 11 months ago

mikeus-hanzlik commented 11 months ago

Fixes #6673

Description

After upgrade from ADAL to MSAL auth library, sendX5C flag was not set and it breaks SN+I authentication with AAD app registrations.

Specific Changes

Added sendX5C flag to ConfidentialClientApplicationBuilder.WithCertificate() method.

Testing

Tested locally and also on our repo by implementing this fix on an inherited class.