microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 479 forks source link

[Teams] Add support for meeting participants added/removed events #6677

Closed ceciliaavila closed 1 year ago

ceciliaavila commented 1 year ago

minor

Description

This PR is based on #5809. It adds support to TeamsActivityHandler for meeting participant join/leave events.

Specific Changes

Testing

These images show the new unit tests passing and the implementation tested with a sample. image image image

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 364374


Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableDate.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableDate.cs 1 93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs 2 96.39%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs 6 79.35%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 6 89.62%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Converters/InterfaceConverter.cs 10 81.16%
<!-- Total: 27 -->
Totals Coverage Status
Change from base Build 362013: -0.006%
Covered Lines: 25959
Relevant Lines: 32869

💛 - Coveralls
ceciliaavila commented 1 year ago

Hi @tracyboehrer, there's a problem with the CI pipeline in this PR. We think is related to the custom Nuget feed. Please, let us know if we can help solve this. Thanks.

BruceHaley commented 1 year ago

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll