microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

872 stars 479 forks source link

Resolve concurrency issues in InterfaceConverter's ReadJson method #6681

Closed InfinytRam closed 1 year ago

InfinytRam commented 1 year ago

minor

Closes IcM: https://portal.microsofticm.com/imp/v3/incidents/details/403753372/home

Description

This PR addresses concurrency issues observed in the InterfaceConverter's ReadJson method. The changes ensure thread-safe operations when deserializing JSON concurrently.

Specific Changes

Replaced Dictionary<string, T> type declarations with ConcurrentDictionary<string, T> for rangeReferences, cachedRefDialogs and cachedTypes.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 363742

0 of 0 changed or added relevant lines in 0 files are covered.
21 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.03%) to 78.956%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableDate.cs	1	90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableDate.cs	1	93.94%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs	1	93.55%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs	2	96.39%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs	6	89.62%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Converters/InterfaceConverter.cs	10	81.16%
<!--	Total:	21	-->

Totals
Change from base Build 362013:	-0.03%
Covered Lines:	25937
Relevant Lines:	32850