search

microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.
https://github.com/Microsoft/botframework
MIT License
872 stars 479 forks source link

Drop ADAL to unblock pipeline #6687

Closed Danieladu closed 1 year ago

Danieladu commented 1 year ago

Fixes #minor

Description

ADAL library (Microsoft.IdentityModel.Clients.ActiveDirectory,Microsoft.Azure.Services.AppAuthentication ) has been marked deprecated and would block the Azure pipeline on 23 September.

Totally remove ADAL code to unblock the pipeline

Danieladu commented 1 year ago

CI exception: image I think it make sense? Because we remove the ADAL code, which has been marked deprecate longlong ago.

Danieladu commented 1 year ago

I have updated the variable, but seems not work image Is there any additional thing should i do?

sw-joelmut commented 1 year ago

Hi @Danieladu,

We want to share our findings regarding the ApiCompatExcludeClasses variable. The variable is working as expected, but you will need to execute the pipeline (new run, not retry) for the changes to be applied. imagen

Additionally, there is another way of excluding the classes. All compatibility issues shown in the Compatibility Check pipeline's section can be excluded by adding them to the ApiCompatBaseline.txt file. imagen

Danieladu commented 1 year ago

@microsoft/botframework-sdk @tracyboehrer please help review this PR which blocks the SDK pipeline and also ABS pipeline.