microsoft / botbuilder-dotnet

Welcome to the Bot Framework SDK for .NET repository, which is the home for the libraries and packages that enable developers to build sophisticated bot applications using .NET.

https://github.com/Microsoft/botframework

MIT License

872 stars 479 forks source link

Remove unused deprecated adal package #6689

Closed mit2nil closed 4 months ago

mit2nil commented 1 year ago

minor

tracyboehrer commented 1 year ago

We're going to hold on this. There are other alerts coming from the affected test project. This shouldn't not effect anyone consuming BF SDK packages as it's not published as a dependency. It exists only to run unit tests for the Connector package. There is another effort underway to correct this project though.

ceciliaavila commented 1 year ago

Hi @tracyboehrer, this PR should solve the compliance blocker in Microsoft.Bot.Connector.Tests. We reviewed the rest of the project and there are no more references to ADAL. Thanks. Edit: This solves partially the compliance blocker. We are working on the remaining ADAL reference.

tracyboehrer commented 1 year ago

@ceciliaavila There is also an alert related to Microsoft.Rest.ClientRuntime.Azure.TestFramework

tracyboehrer commented 4 months ago

This was resolved in: https://github.com/microsoft/botbuilder-dotnet/pull/6690